Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-141728

QQmlPropertyCache. Don't add property if override semantics are invalid

XMLWordPrintable

      Before adding QQmlPropertyData (imo better to be named as AttributeData to minimize confusion and have corresponding views like Property, Method, etc.) to PropertyCache we check override semantics. The adding happens in 2 steps: adding data, making it accessible by name.

       

      Currently in both cases (filling up PropertyCache from IR and from MetaObject ) we add QQmlPropertyData even in cases when "check fails". It's not clear why we actually need to do that and it introduces confusion to the expectations of the PropertyCache... like the append/addition is still happening, but the data is not exposed.

       

      Most likely at least for the IR side for the properties it can easily be removed, since there is an early exit in that function and error-out. Other cases need to be assessed.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            qtqmlteam Qt Qml Team User
            dima.a Dmitrii Akshintsev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes