Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-14406

QItemSelectionModel::clearSelection() should be virtual

    XMLWordPrintable

Details

    Description

      QItemSelectionModel::clear() is virtual, allowing the user to customize the clear operation e.g. to provide additional housekeeping to be executed. However, QItemSelectionModel::clearSelection() is not virtual, so if any code calls this, the additional derived-class behaviour of clear() is never executed.
      I would suggest just making the clearSelection() slot also virtual; or make both non-virtual!

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            stephen.kelly Stephen Kelly (Unused account) (Inactive)
            cfs_sh Simon Harvey
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes