Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-15185

QGraphicsLayoutItem::getContentsMargins violates Qt coding style

XMLWordPrintable

      Came across this today: http://doc.qt.nokia.com/4.7/qgraphicslayoutitem.html#getContentsMargins

      That's just poor API. Reasons:

      • A getter function that returns void,
      • A getter function in Qt with a get prefix,
      • Four out params.

      Proposed fix: Have a ContentsMargins struct that can be used as a return value. Will get rid of the out params. And drop the get prefix.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Unassigned Unassigned
            mikhas Michael Hasselmann
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes