Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-16583

Version resource scripts lack language; this causes warnings in some installation situations

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Done
    • Icon: P2: Important P2: Important
    • 4.8.0
    • 4.7.1
    • Other
    • None
    • Windows 7

    • 5ccd3443fb4604d67a8f65588cc2e3b61c9e1b5c

      The resource scripts for the Qt DLL's lack a language property. I'm not sure if excluding this is merely a preference or a bug ... I'm not familiar enough with the schema of resource scripts. The consequences of this are: (a) the resource information cannot be seen from Windows Explorer (which suggests to me that it may be a bug, being a malformed resource script) ... see attached screenshot; (b) it causes warnings when deploying the DLL's in conformant installers (such as WiX) because the Windows Installer schema expects a language for every non-font file resource. This is not a fatal warning, but can cause patching and upgrade scenario problems.

      This can be amended by identifying the DLL's as language neutral. For example, changing QtGui_resource.rc as follows:

      ...
      BEGIN
      	BLOCK "StringFileInfo"
      	BEGIN
      		BLOCK "040904B0"
      		BEGIN
      			VALUE "CompanyName", "Nokia Corporation and/or its subsidiary(-ies)\0"
      			VALUE "FileDescription", "C++ application development framework.\0"
      			VALUE "FileVersion", "4.7.1.0\0"
      			VALUE "LegalCopyright", "Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).\0"
      			VALUE "OriginalFilename", "QtGui4.dll\0"
      			VALUE "ProductName", "Qt4\0"
      		END
      	END
      	BLOCK "VarFileInfo"
      	BEGIN
      		VALUE "Translation", 0x000, 0000
      	END
      END
      ...
      

      With this change, the properties now show up in Windows Explorer and (more importantly) conform to the expected format for Windows Installer (see attached screenshot.)

        1. good.png
          good.png
          18 kB
        2. code.txt
          0.7 kB
        3. bad.png
          bad.png
          16 kB
        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            jbornema Joerg Bornemann
            dmateer Dave Mateer
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes