Remove QApplication::processEvents() in QFileSystemModel::setIconProvider() because it has adverse side effects

QFileSystemModel::setIconProvider() calls QApplication::processEvents().

Depending on the position QFileSystemModel::setIconProvider() is called, this can lead to the following adverse side effects:

• GUI displayed in an inconsistent/partially constructed state until the next update (often)

• Crash, if QApplication::processEvents() enters an event method of a widget that is currently beeing constructed at the position setIconProvider() is called and uses a member that has not been created yet (sometimes)

Is there a good reason for calling processEvents() in this context? If there isn't, I suggest removing this call alltogether.