Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-1747

qt_intersect_spans needs Q_ASSERT

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Invalid
    • Icon: P3: Somewhat important P3: Somewhat important
    • Some future release
    • 4.3.3
    • GUI: Painting
    • None

      In the file qpaintengine_raster.cpp qt_intersect_spans assumes that rects is never empty. Shouldn't this have a Q_ASSERT() to check this?

      static int qt_intersect_spans(QT_FT_Span *spans, int numSpans,
      int *currSpan,
      QT_FT_Span *outSpans, int maxOut,
      const QRegion &clip)
      {
      const QVector<QRect> rects = clip.rects();
      const int numRects = rects.size();

      int r = 0;
      short miny, minx, maxx, maxy;
      {
      const QRect &rect = rects[0];

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            rodal Samuel Rødal
            dettman Dean Dettman (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes