Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-21965

Qmake can't handle import keyword for dependency generation

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 4.8.0
    • Fix Version/s: 4.8.0
    • Component/s: Build tools: qmake
    • Labels:
      None
    • Commits:
      d2c7193107a170e2884db52272f4d0ee0da62856

      Description

      This bug is revealed by QtWebKit project - https://bugs.webkit.org/show_bug.cgi?id=67799
      It is so annoying bug, because we have to do clean build manually on Snow Leopard buildbots.

      I made a fix for it, feel free to add it to qmake:

      --- a/qmake/generators/makefiledeps.cpp
      +++ b/qmake/generators/makefiledeps.cpp
      @@ -568,7 +568,7 @@ bool QMakeSourceFileInfo::findDeps(SourceFile *file)
                       keyword_len++;
                   }
      
      -            if(keyword_len == 7 && !strncmp(keyword, "include", keyword_len)) {
      +            if ( (keyword_len == 7 && !strncmp(keyword, "include", keyword_len)) || (keyword_len == 6 && !strncmp(keyword, "import", keyword_len)) ) {
                       char term = *(buffer + x);
                       if(term == '<') {
                           try_local = false;
      

        Attachments

        For Gerrit Dashboard: QTBUG-21965
        # Subject Branch Project Status CR V

          Activity

            People

            Assignee:
            buddenha Oswald Buddenhagen
            Reporter:
            ossy Csaba Osztrogon√°c
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes