Description
The 'src/network/access/qnetworkreplyhttpimpl_p.h' file under QtBase seems to be missing '_q_' prefix for the following code:
Q_PRIVATE_SLOT(d_func(), void replyDownloadData(QByteArray)) Q_PRIVATE_SLOT(d_func(), void replyFinished()) Q_PRIVATE_SLOT(d_func(), void replyDownloadMetaData(QList<QPair<QByteArray,QByteArray> >,int,QString,bool,QSharedPointer<char>,qint64)) Q_PRIVATE_SLOT(d_func(), void replyDownloadProgressSlot(qint64,qint64)) Q_PRIVATE_SLOT(d_func(), void httpAuthenticationRequired(const QHttpNetworkRequest &, QAuthenticator *)) Q_PRIVATE_SLOT(d_func(), void httpError(QNetworkReply::NetworkError, const QString &)) #ifndef QT_NO_OPENSSL Q_PRIVATE_SLOT(d_func(), void replySslErrors(const QList<QSslError> &, bool *, QList<QSslError> *)) Q_PRIVATE_SLOT(d_func(), void replySslConfigurationChanged(const QSslConfiguration&)) #endif Q_PRIVATE_SLOT(d_func(), void proxyAuthenticationRequired(const QNetworkProxy &proxy, QAuthenticator *auth)) Q_PRIVATE_SLOT(d_func(), void resetUploadDataSlot(bool *r)) Q_PRIVATE_SLOT(d_func(), void wantUploadDataSlot(qint64)) Q_PRIVATE_SLOT(d_func(), void sentUploadDataSlot(qint64)) Q_PRIVATE_SLOT(d_func(), void emitReplyUploadProgress(qint64, qint64))
The privateSlots test function (tst_headers under QtQA repo) is failing because of Q_PRIVATE_SLOT definition with the following message:
tst_headers.cpp:139: Data Tag: '/home/qt/.pulse2-agent/data/recipes/139758152/base/qt/qtbase/src/network/access/qnetworkreplyhttpimpl_p.h': 'line.contains("_q_")' returned FALSE. ()
Attachments
Issue Links
- relates to
-
QTBUG-15062 Merge QNetworkReplyImpl and QNetworkAccessHttpBackend into QNetworkReplyHttpImpl
- Closed