Details
-
Bug
-
Resolution: Done
-
P3: Somewhat important
-
4.7.4
-
None
Description
When QTextOdWriter is wrting a FrameFormat it uses the following code -
if (format.hasProperty(QTextFormat::BlockTopMargin))
writer.writeAttribute(foNS, QString::fromLatin1("margin-top"), pixelToPoint(qMax(qreal(0.), format.topMargin())) );
if (format.hasProperty(QTextFormat::BlockBottomMargin))
writer.writeAttribute(foNS, QString::fromLatin1("margin-bottom"), pixelToPoint(qMax(qreal(0.), format.bottomMargin())) );
if (format.hasProperty(QTextFormat::BlockLeftMargin))
writer.writeAttribute(foNS, QString::fromLatin1("margin-left"), pixelToPoint(qMax(qreal(0.), format.leftMargin())) );
if (format.hasProperty(QTextFormat::BlockRightMargin))
writer.writeAttribute(foNS, QString::fromLatin1("margin-right"), pixelToPoint(qMax(qreal(0.), format.rightMargin())) );
It is checking BlockTopMargin etc. and it should be checking FrameTopMargin etc.
Attachments
| For Gerrit Dashboard: QTBUG-22173 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 37653,1 | Use the right properties when checking the frame's margins | master | qt/qtbase | Status: MERGED | +2 | 0 |
| 37743,1 | Use the right properties when checking the frame's margins | 4.8 | qt/qt | Status: MERGED | +2 | 0 |