Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-22280

Off by one error drawing a line in ProgressBar

    XMLWordPrintable

Details

    • Bug
    • Resolution: Incomplete
    • Not Evaluated
    • None
    • 4.7.2, 4.7.4, 4.8.x
    • None
    • Windows XP/Vista/7

    Description

      In src/gui/styles/qcleanlooks.cpp

      version 4.7.4 line 1733
      version 4.8.0rc1 line 1728

      the coordinate of the second inner shadow line is off by one (or maybe 2) and it draws one pixel outside the widget.

      In patch format:

                  //inner shadow
                  painter->setPen(innerShadow);
                  painter->drawLine(QPoint(rect.left() + 1, rect.top() + 1),
                                    QPoint(rect.right() - 1, rect.top() + 1));
                  painter->drawLine(QPoint(rect.left() + 1, rect.top() + 1),
      -                             QPoint(rect.left() + 1, rect.bottom() + 1));
      +                             QPoint(rect.left() + 1, rect.bottom()));
      
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            Unassigned Unassigned
            rberber Rene Berber
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes