Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-22307

Inappropriate use of QSKIP in QNetworkReply autotest

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P3: Somewhat important P3: Somewhat important
    • Some future release
    • 5.0.0
    • Network
    • None

      In tests/auto/network/access/qnetworkreply/tst_qnetworkreply.cpp, the putToHttpMultipart() test function is effectively disabled with:

      QSKIP("test server script cannot handle PUT data yet");
      

      If this skip was added due to a known bug, it would be better to use QEXPECT_FAIL() here, so that when the bug is fixed the test clearly reports that it needs to be updated. (If this remains a QSKIP, there is no warning that the test is out-of-date and the bug could reappear without anybody being informed.) The QEXPECT_FAIL should refer to an appropriate bug report documenting the known bug.

      If the skip was added to avoid a piece of code that crashes, the text of the skip message must be updated to refer to an appropriate bug report.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            manordheim MÃ¥rten Nordheim
            jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes