Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-22309

Inappropriate use of QSKIP in QSslSocket autotest

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • P3: Somewhat important
    • Some future release
    • 5.0.0
    • Network: SSL
    • None

    Description

      In tests/auto/network/ssl/qsslsocket/tst_qsslsocket.cpp, the wildcard() test function is effectively disabled with:

      QSKIP("TODO: solve wildcard problem");
      

      If this skip was added due to a known bug, it would be better to use QEXPECT_FAIL() here, so that when the bug is fixed the test clearly reports that it needs to be updated. (If this remains a QSKIP, there is no warning that the test is out-of-date and the bug could reappear without anybody being informed.) The QEXPECT_FAIL should refer to an appropriate bug report documenting the known bug.

      If the skip was added to avoid a piece of code that crashes, the text of the skip message must be updated to refer to an appropriate bug report.

      Note also that commenting out the QSKIP reveals that the test also has a compilation error:

      /home/user/depot/qt5-test/qtbase/tests/auto/network/ssl/qsslsocket/tst_qsslsocket.cpp:1296: undefined reference to `bool QTest::qCompare<QStringList, QString>(QStringList const&, QString const&, char const*, char const*, char const*, int)'
      /home/user/depot/qt5-test/qtbase/tests/auto/network/ssl/qsslsocket/tst_qsslsocket.cpp:1297: undefined reference to `bool QTest::qCompare<QStringList, QString>(QStringList const&, QString const&, char const*, char const*, char const*, int)'
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            tpochep Timur Pocheptsov
            jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes