Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-22341

Inappropriate use of QSKIP in QFile autotest

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P3: Somewhat important
    • 5.0.0
    • 5.0.0
    • Core: I/O
    • None

    Description

      In qtbase/tests/auto/corelib/io/qfile/tst_qfile.cpp, the tailFile() test function is disabled with:

      QSKIP("File change notifications are so far unsupported.");
      

      If this skip was added due to a known bug, it would be better to use QEXPECT_FAIL() here, so that when the bug is fixed the test clearly reports that it needs to be updated. (If this remains a QSKIP, there is no warning that the test is out-of-date and the bug could reappear without anybody being informed.) The QEXPECT_FAIL should refer to an appropriate bug report documenting the known bug.

      If this test function is for a feature that is yet to be implemented, it should probably be removed unless the feature is on the roadmap.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            jbornema Joerg Bornemann
            jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes