Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-22466

Inappropriate use of #if 0 in QRegexp autotest

    XMLWordPrintable

Details

    • 1fe7e557d75962c9c79cc344037a02ed50369430

    Description

      In qtbase/tests/auto/corelib/tools/qregexp/tst_qregexp.cpp, two lines of test data are disabled by #if 0. These were originally added in February 2008 a commit described as "Added a commented-out test case for QRegExp for Developer X to look at. Related to qdoc optimization."

      Presumably Developer X never got around to looking at it.

      If the test data is still appropriate, it should be re-enabled and any failures that this reveals should be handled by adding QEXPECT_FAIL calls to the test and raising bug reports for the bugs. If the test data is no longer appropriate, it should be removed.

      Attachments

        For Gerrit Dashboard: QTBUG-22466
        # Subject Branch Project Status CR V

        Activity

          People

            Unassigned Unassigned
            jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes