Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-23987

qgraphicswebview.cpp not compiling due to -Werror and QWebPageClient.h

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Not Evaluated
    • 4.8.3
    • 4.8.0, 4.8.2
    • Build tools: Other
    • None
    • 20e5b74bd94bfae9cf783b0c67dd03ab270e347e

    Description

      Not sure about the component, but here goes:

      GCC 4.3.1 on openSuSE Linux 11.0
      configure options: -no-script -no-scripttools -fast -shared -release -qtlibinfix XXXX -commercial -nomake demos -nomake examples -openssl -no-phonon -no-multimedia -no-accessibility -no-xinerama -prefix /opt/qt/4_8_0 -I /opt/openssl/1.0.0g/include/ -L /opt/openssl/1.0.0g/lib/ -webkit -qt-libjpeg -qt-libpng -qt-libtiff -qt-zlib -qt-libmng

      When compiling src/3rdparty/webkit/Source/WebKit/qt/Api/qgraphicswebview.cpp, gcc gives the following error:

      cc1plus: warnings being treated as errors
      In file included from WebCoreSupport/PageClientQt.h:28,
                       from Api/qgraphicswebview.cpp:31:
      ../../WebCore/platform/qt/QWebPageClient.h:56: error: unused parameter layer
      ../../WebCore/platform/qt/QWebPageClient.h:61: error: unused parameter scheduleSync
      

      This is due to:

      virtual void setRootGraphicsLayer(WebCore::PlatformLayer\* layer) { }
      virtual void markForSync(bool scheduleSync = false) { } 

      So I'm going to work around it by removing the -Werror option. Please fix.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            shausman Simon Hausmann
            cronhan Johan Cronje
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes