Details
-
Bug
-
Resolution: Done
-
Not Evaluated
-
5.0.0
-
Windows 7, MSVC 2010, 64bit
-
6b96c229a5f04599c511843ce0fb8041a74c56b9
Description
Windows: qdeclarativemoduleplugin autotest of qtquick1 fails:
FAIL! : tst_qdeclarativemoduleplugin::importPluginWithQmlFile() 'path.at(0).isUpper() && path.at(1) == QLatin1Char(':')' returned FALSE. () .\tst_qdeclarativemoduleplugin.cpp(192) : failure location
Here is the problem code:
QString path = importsDirectory(); // QTBUG-16885: adding an import path with a lower-case "c:" causes assert failure // (this only happens if the plugin includes pure QML files) #ifdef Q_OS_WIN QVERIFY(path.at(0).isUpper() && path.at(1) == QLatin1Char(':')); path = path.at(0).toLower() + path.mid(1); #endif
The failure is caused by drive letter being wrong case. The whole QVERIFY here is pointless, as all it is doing is verifying what QTest::qFindTestData() returned earlier when resolving the imports directory (path variable), which is in no way related to this test. The drive letter is anyway corrected on the very next line.
Attachments
Issue Links
- is required for
-
QTBUG-24203 Qt 5.0 - Windows: Fix tests
- Closed
For Gerrit Dashboard: QTBUG-24471 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
17415,1 | Windows: Fix qdeclarativemoduleplugin test | master | qt/qtquick1 | Status: MERGED | +2 | 0 |