Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-25296

Fix insignificant QMacStyle test

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P2: Important
    • None
    • None
    • Widgets: Style Sheets
    • None

    Description

      qtbase/tests/auto/widgets/styles/qmacstyle/qmacstyle.pro is marked as an insignificant_test, meaning that it is not used to block regressions in CI.

      Examining recent CI logs, the test appears to fail in a stable fashion, suggesting that test coverage could be increased by replacing the insignificant_test marker with QEXPECT_FAIL calls.

      4/13/12 3:59:20 PM EST: Testing tst_QMacStyle
4/13/12 3:59:20 PM EST: FAIL!  : tst_QMacStyle::sizeHints(normal) Compared values are not the same
4/13/12 3:59:20 PM EST:    Actual   (sh(&radio1).height()): 14
4/13/12 3:59:20 PM EST:    Expected (SIZE(15, 12, 10)): 15
4/13/12 3:59:20 PM EST:    Loc: [tst_qmacstyle.cpp(138)]
4/13/12 3:59:20 PM EST: FAIL!  : tst_QMacStyle::smallMiniNormalExclusivity(normal small mini) Compared values are not the same
4/13/12 3:59:20 PM EST:    Actual   (size.height()): 17
4/13/12 3:59:20 PM EST:    Expected (expected[i]): 16
4/13/12 3:59:20 PM EST:    Loc: [tst_qmacstyle.cpp(404)]
4/13/12 3:59:20 PM EST: FAIL!  : tst_QMacStyle::smallMiniNormalExclusivity(normal mini small) Compared values are not the same
4/13/12 3:59:20 PM EST:    Actual   (size.height()): 24
4/13/12 3:59:20 PM EST:    Expected (expected[i]): 16
4/13/12 3:59:20 PM EST:    Loc: [tst_qmacstyle.cpp(404)]
4/13/12 3:59:20 PM EST: FAIL!  : tst_QMacStyle::smallMiniNormalExclusivity(small normal mini) Compared values are not the same
4/13/12 3:59:20 PM EST:    Actual   (size.height()): 17
4/13/12 3:59:20 PM EST:    Expected (expected[i]): 16
4/13/12 3:59:20 PM EST:    Loc: [tst_qmacstyle.cpp(404)]
4/13/12 3:59:20 PM EST: FAIL!  : tst_QMacStyle::smallMiniNormalExclusivity(small mini normal) Compared values are not the same
4/13/12 3:59:20 PM EST:    Actual   (size.height()): 17
4/13/12 3:59:20 PM EST:    Expected (expected[i]): 16
4/13/12 3:59:20 PM EST:    Loc: [tst_qmacstyle.cpp(404)]
4/13/12 3:59:20 PM EST: FAIL!  : tst_QMacStyle::smallMiniNormalExclusivity(mini small normal) Compared values are not the same
4/13/12 3:59:20 PM EST:    Actual   (size.height()): 24
4/13/12 3:59:20 PM EST:    Expected (expected[i]): 16
4/13/12 3:59:20 PM EST:    Loc: [tst_qmacstyle.cpp(404)]
4/13/12 3:59:20 PM EST: FAIL!  : tst_QMacStyle::smallMiniNormalExclusivity(mini normal small) Compared values are not the same
4/13/12 3:59:20 PM EST:    Actual   (size.height()): 24
4/13/12 3:59:20 PM EST:    Expected (expected[i]): 32
4/13/12 3:59:20 PM EST:    Loc: [tst_qmacstyle.cpp(404)]
4/13/12 3:59:20 PM EST: Totals: 4 passed, 7 failed, 0 skipped

      Attachments

        Issue Links

          is required for

          Task - A task that needs to be done. QTBUG-24131 Autotests for Qt 5.0 on OSX

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-25296
          # Subject Branch Project Status CR V
          23740,2 Re-enable the QMacStyle test. master qt/qtbase Status: MERGED +2 0

          Activity

            People

              Unassigned Unassigned
              jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are no open Gerrit changes