Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-25297

Fix insignificant QMdiSubWindow test

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Duplicate
    • Icon: P2: Important P2: Important
    • None
    • None
    • Widgets: Widgets and Dialogs
    • None

      qtbase/tests/auto/widgets/widgets/qmdisubwindow/qmdisubwindow.pro is marked as an insignificant_test, meaning that the results are discarded and not used by the CI system to block regressions.

      Examining recent CI logs shows that the test fails consistently on mac and fails inconsistently on Linux.

      linux failure
      4/13/12 10:36:51 AM EST: Testing tst_QMdiSubWindow
4/13/12 10:36:56 AM EST: FAIL!  : tst_QMdiSubWindow::emittingOfSignals(windowRestored) '!window->isMaximized()' returned FALSE. ()
4/13/12 10:36:56 AM EST:    Loc: [tst_qmdisubwindow.cpp(103)]
4/13/12 10:36:56 AM EST: Totals: 41 passed, 1 failed, 30 skipped
      mac failure
      4/13/12 4:02:45 PM EST: Testing tst_QMdiSubWindow
4/13/12 4:02:45 PM EST: Apr 13 16:02:18 bq-mac-mini-18.apac.nokia.com tst_qmdisubwindow[87588] <Error>: CGImageCreate: invalid image size: 0 x 0.
4/13/12 4:02:45 PM EST: Apr 13 16:02:18 bq-mac-mini-18.apac.nokia.com tst_qmdisubwindow[87588] <Error>: CGImageCreate: invalid image size: 0 x 0.
4/13/12 4:02:45 PM EST: Apr 13 16:02:18 bq-mac-mini-18.apac.nokia.com tst_qmdisubwindow[87588] <Error>: CGImageCreate: invalid image size: 0 x 0.
4/13/12 4:02:45 PM EST: FAIL!  : tst_QMdiSubWindow::showShaded() 'mouseReceiver' returned FALSE. ()
4/13/12 4:02:45 PM EST:    Loc: [tst_qmdisubwindow.cpp(614)]
4/13/12 4:02:45 PM EST: FAIL!  : tst_QMdiSubWindow::setOpaqueResizeAndMove(normal mode) 'mouseReceiver' returned FALSE. ()
4/13/12 4:02:45 PM EST:    Loc: [tst_qmdisubwindow.cpp(728)]
4/13/12 4:02:45 PM EST: FAIL!  : tst_QMdiSubWindow::setOpaqueResizeAndMove(rubberband mode) 'mouseReceiver' returned FALSE. ()
4/13/12 4:02:45 PM EST:    Loc: [tst_qmdisubwindow.cpp(728)]
4/13/12 4:02:45 PM EST: FAIL!  : tst_QMdiSubWindow::defaultSizeGrip() 'qFindChild<QSizeGrip *>(windowWithDecoration)' returned FALSE. ()
4/13/12 4:02:45 PM EST:    Loc: [tst_qmdisubwindow.cpp(1436)]
4/13/12 4:02:45 PM EST: FAIL!  : tst_QMdiSubWindow::fixedMinMaxSize() Compared values are not the same
4/13/12 4:02:45 PM EST:    Actual   (subWindow->size()): QSize(196x26)
4/13/12 4:02:45 PM EST:    Expected (minimizedSize): QSize(196x22)
4/13/12 4:02:45 PM EST:    Loc: [tst_qmdisubwindow.cpp(1703)]
4/13/12 4:02:45 PM EST: Totals: 36 passed, 5 failed, 30 skipped

      The stable failure should be replaced by QEXPECT_FAIL calls (and the insignificant_test marker removed for mac) so that the rest of the test can be used by CI to block regressions. The linux failure could potentially be resolved by replacing QVERIFY with QTRY_VERIFY.

        For Gerrit Dashboard: QTBUG-25297
        # Subject Branch Project Status CR V
        23867,1 Remove insignification from QMdiSubWindow test on Mac OS X. master qt/qtbase Status: MERGED +2 0
        46812,2 Cocoa: Add QMdiSubWindow size grip back. stable qt/qtbase Status: MERGED +2 0

            sorvig Morten Sørvig
            jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes