Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-2657

Need comment to tr("+") in qkeysequence.cpp

    XMLWordPrintable

Details

    • ac00b5155eb3fc449d7a845508f1114e0c78d89e (qt/qtbase/wip/qt6)

    Description

      The addKey method currently encloses the "+" sign with a tr call, but no comment.

      static inline void addKey(QString &str, const QString &theKey, QKeySequence::SequenceFormat format)
{
    if (!str.isEmpty())
        str += (format == QKeySequence::NativeText) ? QShortcut::tr("+")
                                                    : QString::fromLatin1("+");
    str += theKey;
}

      It would be nice if there was context information added, like the following:

      QShortcut::tr("+", "Key separator in shortcut string")

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            laknoll Lars Knoll
            dettman Dean Dettman (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes