Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-27428

qmake doesn't generate complete .rc file on Windows

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P3: Somewhat important
    • Resolution: Done
    • Affects Version/s: 4.8.3
    • Fix Version/s: 5.0.0 RC 2
    • Component/s: Build tools: qmake
    • Labels:
      None
    • Environment:
      Windows 7 x64
      Qt library 4.8.3
      Qt Creator 2.5.2
      Microsoft Visual C++ Compiler 10.0 x86

      Description

      In a .pro file if one specifies:
      VERSION = 1.2.3
      QMAKE_TARGET_COMPANY = My Company
      QMAKE_TARGET_DESCRIPTION = My Product description
      QMAKE_TARGET_COPYRIGHT = My Company Inc.
      QMAKE_TARGET_PRODUCT = My Product

      The result .rc file does not contain:
      BLOCK "StringFileInfo"
      BEGIN
      BLOCK "040904B0"
      BEGIN
      VALUE "CompanyName", "My Company"
      VALUE "FileDescription", "My Product description\0"
      VALUE "FileVersion", "1.2.3\0"
      VALUE "InternalName", "MyProduct\0"
      VALUE "LegalCopyright", "My Company Inc.\0"
      VALUE "LegalTrademarks", "All Rights Reserved\0" - MISSING
      VALUE "LegalTrademarks1", "All Rights Reserved\0" - MISSING
      VALUE "LegalTrademarks2", "\0" - MISSING
      VALUE "OriginalFilename", "MyProduct.dll\0"
      VALUE "ProductName", "MyProduct\0"
      VALUE "ProductVersion", "1.2.3\0" - MISSING
      END
      END

      I've looked at the qmake parser:
      qt-everywhere-opensource-src-4.8.3\qmake\generators\win32\winmakefile.cpp, line 385:
      void Win32MakefileGenerator::processRcFileVar()
      {
      ...
      }

      and found that it doesn't print any of the following tags:
      "LegalTrademarks"
      "LegalTrademarks1"
      "LegalTrademarks2"
      "ProductVersion" - MOST IMPORTANT

      The missing data is seen in the result binary:
      1) Using Windows Explorer, navigate to the binary built from your project.
      2) Right-click on it and select "Properties" (or hit Alt+Enter when it is selected).
      3) Go to the "Details" tab of the "Properties" dialog.

      "Product version" field is empty as seen in the image attached to this bug report.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            jbornema Joerg Bornemann
            Reporter:
            caravanio Caravanio Napajejenunedkov
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes