Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-28493

Compile plugins/avfoundation/mediaplayer/avfvideowidget.mm with macx-clang-libc++

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 5.0.0 RC 1, 5.0.0
    • Fix Version/s: 5.0.0
    • Component/s: Multimedia
    • Labels:
      None
    • Environment:
      MacOS X 10.8.2
      Apple clang version 4.1 (tags/Apple/clang-421.11.66) (based on LLVM 3.1svn)
      macx-clang-libc++
    • Commits:
      945e8c9f8ed324e0a600dc97b81c3166979fcd8a

      Description

      Both Qt 5.0.0rc1 (qt-everywhere-opensource-src-5.0.0-rc1) and Qt5 repository fail to build. Both require patch to src/plugins/avfoundation/mediaplayer/avfvideowidget.mm to compile with -platform macx-clang-libc++

      index 3075398..a6a2f42 100644
      --- a/src/plugins/avfoundation/mediaplayer/avfvideowidget.mm
      +++ b/src/plugins/avfoundation/mediaplayer/avfvideowidget.mm
      @@ -103,11 +103,11 @@ void AVFVideoWidget::paintGL()
               return;
       
           QRect targetRect = displayRect();
      -    int x1 = targetRect.left();
      -    int x2 = targetRect.right();
      -    int y1 = targetRect.bottom();
      -    int y2 = targetRect.top();
      -    int zValue = 0;
      +    GLfloat x1 = targetRect.left();
      +    GLfloat x2 = targetRect.right();
      +    GLfloat y1 = targetRect.bottom();
      +    GLfloat y2 = targetRect.top();
      +    GLfloat zValue = 0;
       
           const GLfloat textureCoordinates[] = {
               0, 0,
      

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            • Assignee:
              janichol Andy Nichols
              Reporter:
              moonhoku Paul Sydney
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes