Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-29033 Remaining issues for Qt for Android
  3. QTBUG-29467

Android: Make separate patches for all the non-android changes in the main commit

    XMLWordPrintable

Details

    • Sub-task
    • Resolution: Done
    • P1: Critical
    • 5.1.0
    • Other
    • None

    Description

      Due to the way the project was started, it begins with one large commit. This contains mainly Android-specific things, which are fine to do in a bulk commit, but it also has a few non-android-specific fixes which we need to get reviewed.

      These need to be separated out into their own commits and pushed to dev as soon as possible so we can get reviews for them.

      Here's the files with non-android-specific changes:

      • moc.prf
      • qt_parts.prf
      • static.prf
      • qiconvcodec_p.h
      • qnamespace.h
      • qgraphicsitem.cpp (related to above)
      • qwidget.cpp (related to above)
      • qtextedit.cpp (related to above)
        . qeventdispatcher_unix.cpp
      • qsslcertificate.cpp
      • qfbscreen.cpp
      • moc.cpp
      • qmenu.cpp
      • qcombobox.cpp

      We either need reviews for these in general, or we need to protect the code by #ifdef ANDROID.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            esabraha Eskil Abrahamsen Blomfeldt
            esabraha Eskil Abrahamsen Blomfeldt
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes