Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-30105

qdoc doesn't recognize Q_REVISION macro

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: P2: Important P2: Important
    • 5.1.0
    • 5.0.2
    • Documentation
    • None
    • f226e7e6315745705b153268e18defdeccb41a03

      qdoc is not handling the Q_REVISION macro properly. Consequently the doc bot complains whenever we submit a patch that contains a revisioned slot or signal, for example this change:

      https://codereview.qt-project.org/#change,49777

      qtbase/src/gui/kernel/qwindow.h:286: warning: No documentation for 'QWindow::Q_REVISION()'

      And the actual output docs contain several signals like this:

      QWindow::Q_REVISION() [signal]

      when the source looked like this

      Q_SIGNALS:
      ...
      Q_REVISION(1) void minimumWidthChanged(int arg);

      Slots can have revisions too, like this

      Q_REVISION(1) void setMinimumWidth(int w);

      And properties can be declared with revisions, like this:

      Q_PROPERTY(int minimumWidth READ minimumWidth WRITE setMinimumWidth NOTIFY minimumWidthChanged REVISION 1)

      but the property declaration is not causing any trouble.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            veshivas Venugopal Shivashankar
            srutledg Shawn Rutledge
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes