Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-32374

QDBusAbstractInterface::isValid() returns false for p2p connections

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: P3: Somewhat important P3: Somewhat important
    • 5.1.1
    • 4.8.5, 5.1.0
    • D-Bus
    • None

      QDBusAbstractInterface::isValid() returns true only if the currentOwner is not empty, which will never be the case for a p2p connection.
      I would like to propose two changes:

      1) For p2p connections, completely ignore the service parameter in the QDBusAbstractInterface constructor (currently, if a service name is given, the QDBusAbstractInterfacePrivate constructor will call getNameOwner on the connection, which will fail).

      2) For p2p connections, make isValid() return true if the connection is connected and the isValid private member is true.

      I could try to provide a patch if desired (and I wonder, could we get this to Qt 4.8 as well?).

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            mardy Alberto Mardegan
            mardy Alberto Mardegan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes