-
Bug
-
Resolution: Done
-
P2: Important
-
5.1.0 , 5.1.1, 5.2.0
-
None
-
Ubuntu 13.10
-
f6f797a6c3b794d14c312855bacc8b5b89ea6127
Icon Theme Specification (http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html) states that /usr/share/pixmaps should be one of the default paths to search for icons. Currently QIconLoader does not support loading icons from this directory.
The spec also says that XPM icons must be supported (although for backwards compability reasons).
In order to load icons from ~/.icons and /usr/share/pixmaps QIconLoader must also implement a fallback to load icons directly from base dirs (as stated in the spec).
I've prepared patches to fix these missing functionalities.
QGenericUnixTheme::xdgIconThemePaths: add /usr/share/pixmaps:
https://codereview.qt-project.org/63987
QIconLoader::findIconHelper: also search for XPM images:
https://codereview.qt-project.org/63988
QIconLoader::loadIcon: search icons directly from base dirs:
https://codereview.qt-project.org/63989
Add QIcon::fromTheme() unit tests:
https://codereview.qt-project.org/63990
- relates to
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Open
-
| For Gerrit Dashboard: QTBUG-33123 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 63988,4 | QIconLoader::findIconHelper: also search for XPM images | dev | qt/qtbase | Status: NEW | -1 | 0 |
| 63987,3 | QGenericUnixTheme::xdgIconThemePaths: add /usr/share/pixmaps | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 63989,5 | QIconLoader::loadIcon: search icons directly from base dirs | 5.8 | qt/qtbase | Status: ABANDONED | 0 | 0 |
| 63990,10 | Add QIcon::fromTheme() unit tests | 5.8 | qt/qtbase | Status: ABANDONED | 0 | 0 |
| 173965,2 | Fix QIcon::actualSize() and QIcon::availableSizes() for unthemed icons | 5.8 | qt/qtbase | Status: ABANDONED | 0 | 0 |
| 215085,4 | Introduce QIcon::fallbackSearchPaths() | dev | qt/qtbase | Status: MERGED | +2 | 0 |