Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-3349

getExistingDirectory() duplicate keyboard accelerator

    XMLWordPrintable

Details

    Description

      When invoking QFileDialog::getExistingDirectory() there are buttons &Choose and &Cancel; it is bad practice to have duplicate keyboard accelerators like this.

      In :const char *QDialogButtonBoxPrivate::standardButtonText(QDialogButtonBox::StandardButton sbutton) const

      There is a case that looks like this:

      case QDialogButtonBox::Cancel:
      buttonText = gnomeLayout ? QT_TRANSLATE_NOOP("QDialogButtonBox", "&Cancel") : QT_TRANSLATE_NOOP("QDialogButtonBox", "Cancel");

      Meaning that if you are using a gnomeLayout for your dialogs, and you use a QFileDialog::getExistingDirectory(), then there will be 2 "C" keyboard accelerators.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            laknoll Lars Knoll
            janichol Andy Nichols
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes