Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-33994

Qt5.2.0 Beta1: Icu patching

XMLWordPrintable

      From Iikka Eklund on basis of the attached RTA test logs which contain the 'icu_install' text findings on Qt5.2.0 Beta1 installer packages:

      The icu patching is implemented here:

      e.g.
      /release-tools/configurations/pkg_520/qt.520.gcc.essentials/data/patcher.sh

      sed -i -e
      's/-[I|L]\"\/data\/bamboo\/xml-data\/build-dir.*icu_install\/.[\"
      $]//g' "${tmpfilenames[@]}"

      well this is rather obvious, the patcher script tries to grep
      bamboo based build paths. Now the paths are Jenkins based.
      So the regexp needs adjusting for 520 packages.

      (uh oh..if we need to rebuild 5.0.2 - 5.1.x with jenkins, e.g.
      security fix, then the patcher.sh needs to be updated for these
      as well)

      The whole icu path patching is a pita but we need to handle it
      anyways.

      To update the patcher.sh now, the best option for regexp update
      would be to accept both:

      /work/build/icu_install and
      /data/bamboo

      as starting strings which to match.

      ps. as we patch these as empty strings we could do this even
      in mkqt5bld.py.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            iknd Iikka Eklund
            tarjasundqvist Tarja Sundqvist
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes