Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-34058

qwineventnotifier.h pulls windows.h and pulled by QtCore and pulled by all other modules

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • 5.2.0 RC1
    • 5.1.1
    • Core: Event loop
    • None
    • 721ec985011489b35ec9fd4f3c3cb9d51864f003

    Description

      because windows.h is pulled, so when we include QtCore,
      we will pull a lots of windows.h macro definition to pollute the namespace.
      wanna that can be removed from qwineventnotifier.h,
      just simple use void* replace HANDLE.
      or just define HANDLE as void* and then undefine it.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-107179 QtCore includes wingdi.h

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          replaces

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-34282 QtCore include pulls qt_windows.h in

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-34058
          # Subject Branch Project Status CR V
          68171,1 Don't include windows.h in qwineventnotifier.h stable qt/qtbase Status: ABANDONED +2 0

          Activity

            People

              jbornema Joerg Bornemann
              lygstate Yonggang Luo
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes