Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-34735

Wrong time zone database name in documentation and API

    XMLWordPrintable

    Details

    • Commits:
      6bf759b31040fb5d05044cd14d5889fbd19a8942

      Description

      The newly introduced QTimeZone class uses "Olsen" instead of the correct "Olson" both in the class documentation and in the code itself.

      The IANA time zone database is known under various names, one of which is "the Olson database", after its creator, Arthur David Olson:
      http://en.wikipedia.org/wiki/Tz_database

      See the documentation of the class in the snapshot:
      http://doc-snapshot.qt-project.org/qt5-stable/qtimezone.html

      In the code, "Olsen" is used in several parameter names and in at least five function names:

      QByteArray olsenIdToWindowsId(const QByteArray & olsenId)
      QByteArray windowsIdToDefaultOlsenId(const QByteArray & windowsId)
      QByteArray windowsIdToDefaultOlsenId(const QByteArray & windowsId, QLocale::Country country)
      QList<QByteArray> windowsIdToOlsenIds(const QByteArray & windowsId)
      QList<QByteArray> windowsIdToOlsenIds(const QByteArray & windowsId, QLocale::Country country)

      This was noticed in the source package of the Qt 5.2-beta1 release. It's possible that it's been already fixed in the code repository.

      Since it involves only string substitution, I think it should be better to be fixed before the final release instead of in some subsequent release.

      Note that something else can be instead of the correct form of the name, such as "IANA".

        Attachments

        For Gerrit Dashboard: QTBUG-34735
        # Subject Branch Project Status CR V

          Activity

            People

            Assignee:
            johnlayt John Layt
            Reporter:
            daggerstab Bogdan Marinov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes