Details
-
Bug
-
Resolution: Done
-
P2: Important
-
5.2.0 Beta1
-
None
-
Linux
-
e26f5093c6d99c5b9632c3a0375c202bf4dbe627
Description
I just ran the static analyser cppcheck over the source code
of qtmultimedia-opensource-src-5.2.0-beta1
It said
[qgstreamerrecordercontrol.cpp:100] -> [qgstreamerrecordercontrol.cpp:102]: (warning) Variable 'sessionState' is reassigned a value before the old one has been used. 'break;' missing?
Source code is
switch ( m_session->state() )
{ case QGstreamerCaptureSession::RecordingState: sessionState = QMediaRecorder::RecordingState; case QGstreamerCaptureSession::PausedState: sessionState = QMediaRecorder::PausedState; case QGstreamerCaptureSession::PreviewState: case QGstreamerCaptureSession::StoppedState: sessionState = QMediaRecorder::StoppedState; }Suggest add the three missing break statements.
Attachments
For Gerrit Dashboard: QTBUG-34914 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
73667,2 | GStreamer: add missing breaks in QGstreamerRecorderControl. | stable | qt/qtmultimedia | Status: MERGED | +2 | 0 |