Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-34925

qtwebkit-opensource-src-5.2.0-beta1:qquickwebview.cpp:436: possible bad if test ?

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • 5.2.0
    • 5.2.0 Beta1
    • WebKit
    • None
    • Linux
    • 48c1382c33b77b002c1b295b9d2d6c4987526add

    Description

      I just ran the static analyser "cppcheck" over the source code
      of qtwebkit-opensource-src-5.2.0-beta1

      It said

      UIProcess/API/qt/qquickwebview.cpp:436:69: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op]

      Source code is

      if (errorCode == kWKErrorCodeFrameLoadInterruptedByPolicyChange && errorCode == kWKErrorCodePlugInWillHandleLoad) {

      Suggest swap && for ||

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            mibrunin Michael Bruning
            dcb David Binderman
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes