Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-35566

QKdeTheme constructor is private

    Details

    • Type: Bug
    • Status: Open
    • Priority: P3: Somewhat important
    • Resolution: Unresolved
    • Affects Version/s: 5.1.1, 5.2.0
    • Fix Version/s: None
    • Component/s: GUI: Look'n'Feel
    • Labels:
      None

      Description

      Currently, the QKdeTheme platform theme class has a private constructor, disallowing deriving from this class. Each object is created by a special factory, QKdeTheme::createKdeTheme(). The factory method determines automatically the required parameters (from the environment) to the constructor and returns a new object.

      There seems to be no real reason for the constructor to be private. Sometimes, when writing custom platform themes, to conserve the look-and-feel of a given desktop it is useful to be able to derive from an existing KDE theme. Because the constructor is private, it is not possible to enhance existing functionality, the only way being to re-do existing work already performed by Qt5 developers.

      If there is a reason for making the constructor private, please comment. The risk of allocating a QKdeTheme object bypassing the factory seems to be close to 0.
      Making the constructor public would be helpful. While keeping it private seems to not give any obvious + at all.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            • Assignee:
              sil2100 Łukasz Zemczak
              Reporter:
              sil2100 Łukasz Zemczak
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Gerrit Reviews

                There are no open Gerrit changes