Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-35622

QImage.h is breaking 4996 msvc warning

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Not Evaluated
    • 5.2.1
    • 5.2.0
    • Core: Other
    • None
    • Window 7 x64, MSVC 2013
    • e6abf372c6c2514ec8d53fae13cc676d3b55dd00

    Description

      Warning C4996 (http://msdn.microsoft.com/en-us/library/ttcz0bys.aspx) is disabled in our project globally but I noticed that including QImage header from Qt5 sadly is breaking this and enables it again.
      I looked through the code and noticed that is's being disabled in following way:

       
      #pragma warning(disable: 4996)
      
      ...
      
      #pragma warning(default: 4996)
      

      While I believe the correct way to disable it is to write #pragma warning (push) at the beginning before disable and #pragma warning (pop) in the end.
      I really hope that this issue will be fixed.

      PS Not sure about the component which should this issue belong to.

      Attachments

        For Gerrit Dashboard: QTBUG-35622
        # Subject Branch Project Status CR V

        Activity

          People

            thiago Thiago Macieira
            predelnik Sergey Semushin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes