Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-35710

TARGET with space fails to link on Android

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: P2: Important
    • Resolution: Unresolved
    • Affects Version/s: 5.1.1, 5.2.0
    • Fix Version/s: None
    • Component/s: Build tools: qmake
    • Environment:
      Qt5.2 out-of-the-box, on a Windows (Win7 x64, Visual 2010) platform.
    • Platform/s:
      Android

      Description

      When TARGET contains a space, the build fails when reaching link, because the target is not quoted inside the generated makefile.

      Generated Makefile.Debug contains:

      $(TARGET): ... some.h ... $(OBJECTS)
      @if not exist ..\..\..\OSTC_Planner\ mkdir ..\..\..\OSTC_Planner\ & if not exist ..\..\..\OSTC_Planner\ exit 1
      $(LINK) $(LFLAGS) -o $(TARGET) $(OBJECTS) $(OBJCOMP) $(LIBS)

      Should be:
      $(TARGET): ... some.h ... $(OBJECTS)
      @if not exist $(DESTDIR) mkdir $(DESTDIR) & if not exist $(DESTDIR) exit 1
      $(LINK) $(LFLAGS) -o "$(TARGET)" $(OBJECTS) $(OBJCOMP) $(LIBS)

      Note:

      • that DESTDIR is indeed defined earlier
      • that I don't see how the link can depend on .h files
      • that "$(DESTDIR)" might be more wise, as on can put space in the path too

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              • Assignee:
                qtbuildsystem Qt Build System Team
                Reporter:
                jeando JD Gascuel
              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Gerrit Reviews

                  There are no open Gerrit changes