WinRT: QStandardPaths::writableLocation() has potential errors

It would appear that WinRT should not add the testdata suffix in some cases which it currently does. It should also be verified that all returned paths are actually writable (see homePath()).

From: https://codereview.qt-project.org/#patch,sidebyside,84048,3,src/corelib/io/qstandardpaths_winrt.cpp

David Faure 9:56 AM

The winRT implementation seems buggy to me. Further down from what's visible in the diff, it says

if (isTestModeEnabled())
result += QLatin1String("/qttest");

1) this should only happen for Data, AppData and AppLocalData 2) this should also append the domain name and app name in normal mode, not only in test mode.

Or maybe the long-winded code in that block already does something application-specific?

Andrew Knight 12:09 PM

I'm not sure if domain name + app name should be added here... maybe, but it would be the only subdirectory within this directory. The writable directory is always app-specific, likely similar to other sandboxed OSes.

Now that you mention it, homePath() looks a bit fishy as that might not be a writable path...