Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-38640

Serial port that do not implement the full feature set can't be opened

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P4: Low
    • 5.3.1
    • 5.2.1
    • Serial Port
    • None
    • MacOSX, Linux, Unix
    • 63d3fc0c0679a801da54cf390728120338fbd187

    Description

      When an opened device does not implement all the features of a "true" serial port, some settings may not work. Thus, the following:

          if (!d->setBaudRate()
              || !d->setDataBits(d->dataBits)
              || !d->setParity(d->parity)
              || !d->setStopBits(d->stopBits)
              || !d->setFlowControl(d->flowControl)) {
              // || !d->setDataTerminalReady(d->dataTerminalReady) // THIS FAILS
              // || !d->setRequestToSend(d->requestToSend)) {      // THIS FAILS AS WELL
              close();
              return false;
          }
      

      will end up closing a working serial port. For example, a PTY serial port opened by socat will not necessarily have DTR and RTS working. Thus, I suggest that in case those fail, we leave the serial port opening, and emit an error to the user so he can decide to deal or not with the problem.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            dzedsystems Dyami Caliri
            zmo Bernard
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes