Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-39398

Regression: closeEvent called twice

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • 5.3.1
    • 5.3.0
    • QPA
    • OS X 10.9
    • macOS
    • 360fd4a278a8827d9727b295a753e623502c7445

    Description

      QWidget::closeEvent is called twice (it doesn't matter if the event is accepted or not).
      See attached minimal application.
      This is a regression against Qt 5.2.

      For some reason Qt Creator still only got a single closeEvent call, until the patch for fixing QTBUG-37933 was integrated - since then Qt Creator also gets the closeEvent twice, leading to a bunch of issues e.g. regarding saving and restoring sessions.

      Attachments

        1. closeeventtest.zip
          1 kB
          Nick Shaforostoff
        2. closeeventtest.zip
          1 kB
          Eike Ziller

        Issue Links

          is required for

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-39093 Issues to be fixed for Qt 5.3.1

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; Flaky tests; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-37933 Ampersand is removed two times in menues on Cocoa

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-43344 macOS: Regression: closeEvent called twice (still not fixed)

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; Flaky tests; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          For Gerrit Dashboard: QTBUG-39398
          # Subject Branch Project Status CR V
          86758,1 Make tryCloseAllWidgetWindows() close QWindows stable qt/qtbase Status: DEFERRED -1 0
          87051,1 Cocoa: Don't send duplicate close events. stable qt/qtbase Status: MERGED +2 0

          Activity

            People

              sorvig Morten Sørvig
              con Eike Ziller
              Votes:
              2 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes