Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-39967

Windows implementation of QLockFile does not store host name into lock file

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Done
    • Icon: P4: Low P4: Low
    • 5.4.0
    • 5.3.1
    • Core: I/O
    • None
    • Windows

    • 3770f4b1489b8d0d8fd6ffef23b8aac7dbf2e33b (dev, 23.7.2014, 5.4)

      See src\corelib\io\qlockfile_win.cpp:101
      I suggest using qgetenv("COMPUTERNAME") instead of gethostname(). This will not add dependency of WinSock and should give correct results in most Windows configurations. In worst case (if the environment variable is not set) we will get the same results as in current implementation (empty string).

        For Gerrit Dashboard: QTBUG-39967
        # Subject Branch Project Status CR V

            kleint Friedemann Kleint
            bdma Dmitry Bartsevich
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes