Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-40417

[Qt 5 regression] OS X / QMacStyle : PE_IndicatorBranch doesn't honor Qt::RightToLeft option

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 5.4.0, 5.9.6
    • Fix Version/s: 5.9.6
    • Component/s: GUI: Look'n'Feel
    • Labels:
      None
    • Environment:
      Mac OS X 10.9.4
    • Platform/s:
      macOS

      Description

      QMacStyle::drawPrimitive(QStyle::PE_IndicatorBranch, ...) doesn't honor Qt::RightToLeft option. Using Qt 4.8.6 if you use Qt::RightToLeft on a closed disclosure triangle, it draws the arrow pointing right to left. This appears to have been forgotten in Qt 5.

      See qmacstyle_mac.mm, QMacStyle::drawPrimitive(). In Qt 4.8.6:

          case PE_IndicatorBranch: {
           ... 
              if (opt->state & State_Open)
                  bi.value = kThemeDisclosureDown;
              else
                  bi.value = opt->direction == Qt::LeftToRight ? kThemeDisclosureRight : kThemeDisclosureLeft;
      

      The same case in Qt 5.4.0 lacks anything like this.

      I have tested Qt 5.4.0, and I don't know about earlier versions.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            sorvig Morten Sørvig
            Reporter:
            johnweeks John Weeks
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes