Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-40997

Mistaken release of the object

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Not Evaluated
    • Resolution: Done
    • Affects Version/s: 5.3.0, 5.3.1
    • Fix Version/s: 5.3.2
    • Component/s: Multimedia
    • Labels:
      None
    • Environment:
      Win8x64 qt-opensource-windows-x86-msvc2013_opengl-5.3.1
    • Commits:
      389d66b3ed5e2d798e9fb124064523239c393ad8

      Description

      There is mistaken call of pEnum->Release() in line #653. It should be change on pPin->Release().

      source file: plugins/directshow/camera/dscamerasession.cpp
      HRESULT DSCameraSession::getPin(IBaseFilter *pFilter, PIN_DIRECTION PinDir, IPin **ppPin)

      645: while(pEnum->Next(1, &pPin, NULL) == S_OK){
      646: PIN_DIRECTION ThisPinDir;
      647: pPin->QueryDirection(&ThisPinDir);
      648: if(ThisPinDir == PinDir)

      { 649: pEnum->Release(); 650: *ppPin = pPin; 651: return S_OK; 652: }

      653: pEnum->Release(); <---- mistake ( chage on pPin->Release())
      654: }

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            ylopes Yoann Lopes
            Reporter:
            libli Andrew
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes