Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-42546

QNetworkDiskCache: Do not store set-cookie headers of the response in disk cache.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: 5.4.0 Beta
    • Fix Version/s: None
    • Component/s: Network: Cache
    • Labels:
      None

      Description

      At the beginning, QNetworkDiskCache was designed for storing Set-Cookie headers.
      but there was a bug about working the method because of no slot for it.
      It is already fixed recently (QTBUG-41514). BTW, I'm not sure that it has no security problem to store Set-Cookie headers.
      The cookies may contain sensitive information! and It seems that other browsers(Chrome,Chromium,FireFox) don't store Set-Cookie header information in disk-cache.
      I thought it has security problem to store Set-Cookie headers.
      How do you think about this one?

      I Attached the patch not to store and use Set-Cookie headers in disk-cache(with auto test changes).
      Let me know your opinion.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            • Assignee:
              peter-har Peter Hartmann
              Reporter:
              jm86.kim Jeongmin Kim
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Gerrit Reviews

                There are no open Gerrit changes