Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-44009

Add DEPENDS option to qt5_wrap_cpp()

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: P3: Somewhat important P3: Somewhat important
    • 5.6.0 RC
    • 5.4.0
    • Build System: CMake
    • None

      Currently moc rule does not support dependency scanning, so after successful moc file generation it will ignore implicit dependencies in header file.

      Although this works in most typical scenarious at least in one case incremental build becomes broken: when using Q_PLUGIN_METADATA() with FILE argument.

      When FILE refers to JSON file and latter was updated expected behavior is to regenerate moc file. Since CMake add_custom_command() does not support late dependencies setup, all dependencies should be explicitly listed in DEPENDS section.

      https://codereview.qt-project.org/#/c/103876

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            krf Kevin Funk
            dendy Daniel Levin
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes