Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-44268

Stack size calculation does not work for machines where stack grows up

    XMLWordPrintable

Details

    • 9934c075c707138f3e23e7e45858e2f108195b7e

    Description

      On machines where the stack grows upwards (i.e. HPPA) the stack limit calculation does not work (qtdeclarative/src/qml/jsruntime/qv4engine.cpp). The stackBottom is the origin of the stack on this machines, not the limit. Checking if the stack grows up or down should be simply doing:

      if (reinterpret_cast<quintptr>(&stackBottom) < reinterpret_cast<quintptr>(&stackSize))

      { /* grows up */ }

      Since these machines are a rare edge case I suggest to simply assume the stack is big enough on them. In fact qmlviewer seems to work if this check is removed.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            rebemlix Rolf Eike Beer
            rebemlix Rolf Eike Beer
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes