Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-44358

Build failure on big-endian ppc64

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Not Evaluated
    • Resolution: Duplicate
    • Affects Version/s: 5.4.0
    • Fix Version/s: 5.4.1
    • Component/s: Image formats
    • Labels:
      None

      Description

      On big-endian ppc64 qt fails to build:

      image/qimage_conversions.cpp:2257:9: error: expected ‘}’ before numeric constant
      0, 0, 0, 0
      ^
      image/qimage_conversions.cpp:2257:9: error: expected ‘}’ before numeric constant
      image/qimage_conversions.cpp:2257:9: error: expected ‘,’ or ‘;’ before numeric constant
      image/qimage_conversions.cpp:2258:5: error: expected declaration before ‘}’ token
      }, // Format_RGBA8888

      That happens because two commas are missing in
      ./qtbase/src/gui/image/qimage_conversions.cpp

      2250 #if Q_BYTE_ORDER == Q_LITTLE_ENDIAN
      2251 0,
      2252 convert_ARGB_to_ARGB_PM,
      2253 #else
      2254 0,
      2255 0
      2256 #endif
      2257 0, 0, 0, 0
      2258 }, // Format_RGBA8888
      2259
      2260

      { 2261 0, 2262 0, 2263 0, 2264 0, 2265 convert_RGBA_PM_to_RGB, 2266 convert_RGBA_PM_to_ARGB, 2267 convert_RGBA_to_ARGB, 2268 0, 2269 0, 2270 0, 2271 0, 2272 0, 2273 0, 2274 0, 2275 0, 2276 0, 2277 #if Q_BYTE_ORDER == Q_LITTLE_ENDIAN 2278 convert_ARGB_PM_to_RGB, 2279 convert_ARGB_PM_to_ARGB, 2280 0, 2281 #else 2282 0, 2283 0, 2284 0 2285 #endif 2286 0, 0, 0, 0 2287 }

      , // Format_RGBA8888_Premultiplied
      2288

      As you can see there are two missing commas after the zeros above the #endifs.

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              • Assignee:
                allan.jensen Allan Sandfeld Jensen
                Reporter:
                octoploid octoploid
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes