Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-44706

[REG 5.4->5.5] g++ compiler: QString::simplified() clobbers input

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • 5.5.0 Alpha
    • 5.5.0
    • Core: QString and Unicode
    • None
    • g++ compilers
    • 53ce0d1a31c8ebb54952887b8bcf769843d50d9c (qtbase/5.5, 8.3.2015)

    Description

      • Apply qtbug44706.diff to qttranslations repo
      • Open translations/qtquickcontrols_de.ts in Linguist 5.5
      • Note: newlines are only displayed in the German translation, not in the source text edit
      • Save file
      • Do a git diff: Newlines are completely gone

      Discovered while working on https://codereview.qt-project.org/#/c/106727/ , there are some translations with Newlines in QFtp / QPrintDialog which get clobbered each time.

      Reproduceable with:

      • g++ (i686-posix-dwarf-rev2, Built by MinGW-W64 project) 4.9.0
      • g++ (Ubuntu 4.8.2-19ubuntu1) 4.8.2

      NOT Reproduceable with:

      • MSVC 2013

      Attachments

        1. qtbug44076.ts
          0.3 kB
        2. qtbug44706_diag.diff
          3 kB
        3. qtbug44706.diff
          0.5 kB

        Issue Links

          is required for

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-44653 Issues to be fixed before Qt 5.5 Beta

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-53721 [REG 5.2 -> 5.3] QImage's move semantics versions of rgbSwapped() and mirrored() methods break backwards compatibility

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          For Gerrit Dashboard: QTBUG-44706
          # Subject Branch Project Status CR V
          107750,2 WIP: Demonstrate that QString::simplified() modifies input (using a passthrough function) 5.5 qt/qtbase Status: ABANDONED -2 0
          107795,3 QStringAlgorithms::simplified_helper: add missing check for detached 5.5 qt/qtbase Status: MERGED +2 0

          Activity

            People

              thiago Thiago Macieira
              kleint Friedemann Kleint
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes