Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-45190

Add QTextStream::read|readAll|readLine(QString *) overloads to reuse QString's capacity

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Unresolved
    • P3: Somewhat important
    • None
    • None
    • Core: I/O, Core: QString and Unicode
    • None
    • 4
    • Foundation Sprint 120, Foundation Sprint 121, Foundation Sprint 122, Foundation Sprint 123, Foundation Sprint 124, Foundation Sprint 125, Foundation Sprint 126, Foundation Sprint 127, Foundation Sprint 128, Foundation Sprint 129

    Description

      This is a corollary report to QTBUG-45166. QTextStream would be safer (compared to overloads with char* as output parameter) and faster (compared to overloads returning QString) if the following overloads were present to reuse QString's capacity:

      bool QTextStream::readInto(QString *s, qint64 maxLen);
bool QTextStream::readAllInto(QString *s);

      The above overload signatures model along the already existing

      bool QTextStream::readLineInto(QString *s, qint64 maxLen); // already exists

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-57345 Reading a line over 128mb with QTextReader from a file crashes with bad alloc with 32bit application

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Reported

          Suggestion - Public suggestions QTBUG-70484 QIODevice read, readLine, readAll could report errors through optional bool* or lambda

          • P5: Not important - Not relevant and not urgent.
          • Open

          Suggestion - Public suggestions QTBUG-103108 QIODevice is missing QTextStream-line readLineInto()

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Suggestion - Public suggestions QTBUG-113547 [spike] Find out whether QIODevice::readLineInto() is possible to implement without (public) virtual methods

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Suggestion - Public suggestions QTBUG-126574 QIODevice::readLineInto() should have a QSpan overload

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Suggestion - Public suggestions QTBUG-106198 QString: add missing STL-style assign()

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed
          For Gerrit Dashboard: QTBUG-45190
          # Subject Branch Project Status CR V
          609797,9 [QTextStream] Add readInto() and readAllInto() methods dev qt/qtbase Status: NEW +1 0

          Activity

            People

              tatiana.borisova Tatiana Borisova
              ckakman Kayra Akman
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There is 1 open Gerrit change