Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-45357

Let qmake check whether Info.plist is in XML format

    XMLWordPrintable

Details

    • macOS
    • bbad6440ae (qt/qtbase/dev) bbad6440ae (qt/tqtc-qtbase/dev) afdb88a263 (qt/tqtc-qtbase/6.2), aaaa1e251 (6.4)

    Description

      When a user modifies a given Info.plist using a GUI editor, he might save it in binary format, which is perfectly valid in the context of OS X plist format.

      qmake however needs Info.plist in text format (XML) in order to perform the sed command to replace the variables @EXECUTABLE@, @ICON@, @TYPEINFO@, @LIBRARY@, and @SHORT_VERSION@.

      sed command from my Makefile:

      @sed -e "s,@SHORT_VERSION@,1.0,g" -e "s,@FULL_VERSION@,1.0.0,g" -e "s,@TYPEINFO@,????,g" -e "s,@BUNDLEIDENTIFIER@,com.example.product,g" -e "s,@ICON@,myproduct.icns,g" -e "s,@EXECUTABLE@,MyProduct,g" -e "s,@TYPEINFO@,????,g" ../../project/subproject/Info.plist >MyProject.app/Contents/Info.plist
      

      This confuses users.

      I'd love to see a check in the Makefile, that ensures that the file is

      • in text format
      • valid XML

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            blochberger.max Maximilian Blochberger
            webmaster128 Simon Warta
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes