Details
-
Suggestion
-
Resolution: Done
-
P3: Somewhat important
-
5.5.0 Alpha
-
None
Description
Whilst examining the XCB code, I noticed the following:
qxcbconnection_xi2.cpp
static inline qreal fixed1616ToReal(FP1616 val) { return (qreal(val >> 16)) + (val & 0xFFFF) / (qreal)0xFFFF; }
Whilst this is an improvement over an earlier version that used 0xFF, I think this is wrong unless FP1616 has extremely unconventional semantics (such that e.g. 1.FFFF == 2.0000). I think a more plausible definition is simply
qxcbconnection_xi2.cpp
static inline qreal fixed1616ToReal(FP1616 val) { return qreal(val) / 0x1000; }
Attachments
Issue Links
- relates to
-
QTBUG-45375 Jittery lines with Wacom tablet and QTabletEvent
- Closed
For Gerrit Dashboard: QTBUG-45378 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
112335,2 | xcb: Fix FP1616 to double conversion | 5.5 | qt/qtbase | Status: MERGED | +2 | 0 |