On Friday 05 June 2015 10:10:38 Frederik Gladhorn wrote:
> +++ b/src/gui/accessible/qaccessible.h
> @@ -60,7 +60,6 @@ class QTextCursor;
> class Q_GUI_EXPORT QAccessible
> @@ -635,6 +636,12 @@ public:
> static const QString &showMenuAction();
> static const QString &setFocusAction();
> static const QString &toggleAction();
> + static const QString &scrollLeftAction();
> + static const QString &scrollRightAction();
> + static const QString &scrollUpAction();
> + static const QString &scrollDownAction();
> + static const QString &nextPageAction();
> + static const QString &previousPageAction();
> };

This is not Qt-like API. The strings are initialised on first use (all of them)
but they are translated, which means they will not obey a change in
translation settings.

The old ones can't be fixed now, but we should fix the new ones not to return a
const reference.

Reviewed up to math3d and it was good up to that.

–
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center