Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-46559

Q_DECL_OVERRIDEs missing from QtQuickWidgets API

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P2: Important
    • 5.8
    • 5.6
    • Quick: Widget
    • None
    • 62198ab4485e15f350122770d5dfd8de7e59b8f9

    Description

      >On Friday 05 June 2015 10:10:46 Frederik Gladhorn wrote:
      >> +#ifndef QT_NO_DRAGANDDROP
      >> + virtual void dragEnterEvent(QDragEnterEvent *);
      >> + virtual void dragMoveEvent(QDragMoveEvent *);
      >> + virtual void dragLeaveEvent(QDragLeaveEvent *);
      >> + virtual void dropEvent(QDropEvent *);
      >> +#endif
      >> +
      >
      >Is this a public libary?

      Yes.
      >
      >
      >Are the above overrides or not? If they are overrides, add Q_DECL_OVERRIDE.

      The methods are overrides.

      The change looks good except for the missing Q_DECL_OVERRIDE. So far the drag events have been catched in the generic ::event() reimplementation, so nobody could have subclassed these methods in any meaningful way anyway.

      Cheers,
      Lars

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            tvete Paul Olav Tvete
            janihe Jani Heikkinen
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes